fix: resolve all bun audit vulnerabilities with package overrides#338
fix: resolve all bun audit vulnerabilities with package overrides#338
Conversation
Add overrides for 8 vulnerable transitive dependencies: qs, markdown-it, lodash-es, @modelcontextprotocol/sdk, axios, diff, @isaacs/brace-expansion, and hono. This resolves 11 security vulnerabilities including DoS, ReDoS, prototype pollution, XSS, and data leak issues. https://claude.ai/code/session_01D3vmc2S4564FJSFqsRaTfM
|
Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement. To sign the CLA, please add a comment to this PR with the following text: You only need to sign once. After signing, this check will pass automatically. Troubleshooting
|
Greptile SummaryAdds
Confidence Score: 3/5
Important Files Changed
Flowchartflowchart TD
A["package.json overrides"] --> B["Transitive-only overrides"]
A --> C["Direct dependency overrides"]
B --> B1["qs 6.14.1 → 6.15.0<br/>patch"]
B --> B2["markdown-it 14.1.0 → 14.1.1<br/>patch"]
B --> B3["lodash-es 4.17.21 → 4.17.23<br/>patch"]
B --> B4["axios 1.13.2 → 1.13.5<br/>patch"]
B --> B5["@isaacs/brace-expansion 5.0.0 → 5.0.1<br/>patch"]
B --> B6["diff 7.0.0 → 8.0.3<br/>⚠️ MAJOR"]
C --> C1["@modelcontextprotocol/sdk 1.25.3 → 1.26.0<br/>minor"]
C --> C2["hono 4.11.4 → 4.11.9<br/>patch"]
B6 -->|"crosses ^7.0.0 range"| D["@google/gemini-cli-core"]
style B6 fill:#f9f,stroke:#f00,stroke-width:2px
style D fill:#fdd,stroke:#f00
Last reviewed commit: 32ee992 |
| "lodash-es": "4.17.23", | ||
| "@modelcontextprotocol/sdk": "1.26.0", | ||
| "axios": "1.13.5", | ||
| "diff": "8.0.3", |
There was a problem hiding this comment.
Major version override crosses semver boundary
The diff override forces version 8.0.3, but @google/gemini-cli-core declares "diff": "^7.0.0" as its dependency. This is a major version bump (7.x → 8.x) that crosses the declared semver range. Unlike the other overrides which are patch/minor bumps within compatible ranges, this one forces a version that @google/gemini-cli-core was not designed or tested against.
If diff@8 introduced breaking API changes (renamed exports, removed functions, changed signatures), this could cause runtime errors in @google/gemini-cli-core. Consider verifying that the gemini CLI core functionality still works correctly after this override, or check whether @google/gemini-cli-core has a newer version that declares compatibility with diff@8.
Prompt To Fix With AI
This is a comment left during a code review.
Path: package.json
Line: 69:69
Comment:
**Major version override crosses semver boundary**
The `diff` override forces version `8.0.3`, but `@google/gemini-cli-core` declares `"diff": "^7.0.0"` as its dependency. This is a **major version bump** (7.x → 8.x) that crosses the declared semver range. Unlike the other overrides which are patch/minor bumps within compatible ranges, this one forces a version that `@google/gemini-cli-core` was not designed or tested against.
If `diff@8` introduced breaking API changes (renamed exports, removed functions, changed signatures), this could cause runtime errors in `@google/gemini-cli-core`. Consider verifying that the gemini CLI core functionality still works correctly after this override, or check whether `@google/gemini-cli-core` has a newer version that declares compatibility with `diff@8`.
How can I resolve this? If you propose a fix, please make it concise.
Add overrides for 8 vulnerable transitive dependencies: qs, markdown-it, lodash-es, @modelcontextprotocol/sdk, axios, diff, @isaacs/brace-expansion, and hono. This resolves 11 security vulnerabilities including DoS, ReDoS, prototype pollution, XSS, and data leak issues.